Conversation
This was referenced Sep 17, 2026
BubbleCal
force-pushed
the
yang/oss-2269-4-row-lineage-commit
branch
from
September 17, 2026 08:39
9eabcdd to
61a884e
Compare
BubbleCal
force-pushed
the
yang/oss-2269-4-row-lineage-commit
branch
from
September 17, 2026 08:47
61a884e to
26f5630
Compare
BubbleCal
added this pull request to stack #9343
September 17, 2026 08:56
BubbleCal
force-pushed
the
yang/oss-2269-4-row-lineage-commit
branch
from
September 17, 2026 09:49
26f5630 to
465c237
Compare
Building a manifest is synchronous and cannot read a data file, yet two commit-time paths need existing lineage: resolving which rows an update rewrote so each row's created-at version carries over, and overlaying a partial column rewrite's patched offsets onto the fragment's last-updated-at sequence. The commit path in lance now reads every spilled sequence of the current manifest ahead of each build attempt and hands them over in ManifestBuildConfig::spilled_row_lineage; the two paths consult that map for a spilled fragment and still refuse if a sequence they need is missing. UpdateBuilder, merge_insert in both write modes and externally assembled Operation::Updates therefore work on a spilled table unchanged, producing inline lineage for the rewritten rows; the next compaction spills it again. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
BubbleCal
force-pushed
the
yang/oss-2269-4-row-lineage-commit
branch
from
September 17, 2026 10:52
465c237 to
7a97a8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth of the §5.3 stack (#8931, #9250), on top of #9337. Updates on a table with spilled lineage keep every row's lineage, the way they do on an inline table.
Stack
Problem
Building a manifest is synchronous and has no object store. Two commit-time paths need existing lineage: resolving which rows an update rewrote, to carry each row's created-at version over (
resolve_update_version_metadata), and overlaying a partial column rewrite's patched offsets onto the fragment's last-updated-at sequence (refresh_row_latest_update_meta_for_partial_frag_rewrite_cols). Once a fragment's sequences are spilled, neither can read them, and the previous PRs made them refuse withNotSupported.Change
The commit path in
lancereads every spilled sequence of the current manifest ahead of each build attempt (load_spilled_row_lineage, served from the same caches the readers use) and hands them over inManifestBuildConfig::spilled_row_lineage. The two paths consult that map for a spilled fragment and still refuse if a sequence they need is missing, so a caller ofbuild_manifestthat skips the read-ahead gets an error rather than defaulted lineage. Loaded per attempt, so a rebase onto a newer manifest sees that manifest's fragments; onlyUpdateandDataOverlayoperations pay for it.UpdateBuilder,merge_insertin both write modes, and externally assembledOperation::Updates therefore work on a spilled table unchanged. The lineage they produce for the rewritten rows is inline; a refreshed last-updated-at sequence goes back inline as well. An update-heavy table thus regrows its manifest between compactions and the next compaction spills it again.Validation
cargo test -p lance-table row_version(spilled source lineage resolves from the config; missing lineage still refuses)cargo test -p lance --lib rowids::(update keeps the rewritten row's id and created-at; merge_insert keeps matched rows' lineage and stamps inserted ones; a partial column rewrite on a spilled fragment stamps only the patched rows)cargo test -p lance --lib -- rowid row_version stable_row update::tests merge_insert::tests dataset_transactionscargo clippy --all --tests --benches -- -D warnings,cargo fmt --allRefs #8931, #9250
🤖 Generated with Claude Code