Skip to content

feat(sheets): combine chart workflows and special chart types - #2374

Draft
zhengzhijiej-tech wants to merge 26 commits into
mainfrom
feat-chart-opt-special-types-cli
Draft

feat(sheets): combine chart workflows and special chart types#2374
zhengzhijiej-tech wants to merge 26 commits into
mainfrom
feat-chart-opt-special-types-cli

Conversation

@zhengzhijiej-tech

Copy link
Copy Markdown
Collaborator

Problem

Chart workflow improvements and bubble/waterfall/pareto support were developed on separate branches. Keeping them separate leaves the semantic shortcuts, batch paths, generated schemas, and bundled Sheets skill out of sync.

Changes

  • add semantic chart create/config/data-update shortcuts and dedicated chart batch entry points
  • preserve partial chart updates, detached headers, cross-sheet ranges, color themes, and batch error recovery
  • support bubble, waterfall, and pareto charts across examples, schemas, readback, and generated flags
  • add semantic bubble role flags for key/x/y/group/size on create and data update
  • sync the bundled lark-sheets skill from the combined sheet-skill-spec output, including the chart layout check script
  • keep generic +batch-update compatible with chart operations while guiding pure chart batches to the dedicated shortcuts

Validation

  • go test -count=1 ./shortcuts/sheets/...
  • make unit-test
  • make vet
  • make fmt-check
  • node scripts/skill-format-check/index.js skills
  • make quality-gate QUALITY_GATE_CHANGED_FROM=origin/main

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1cd180f5-20e7-4cb1-a2aa-b981e0173057

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added domain/ccm PR touches the ccm domain size/XL Architecture-level or global-impact change labels Aug 18, 2026
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.05552% with 535 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.26%. Comparing base (755daa4) to head (c79a752).

Files with missing lines Patch % Lines
shortcuts/sheets/lark_sheet_chart.go 63.91% 260 Missing and 134 partials ⚠️
shortcuts/sheets/lark_sheet_batch_update.go 63.87% 88 Missing and 37 partials ⚠️
shortcuts/sheets/flag_schema.go 72.97% 7 Missing and 3 partials ⚠️
shortcuts/sheets/batch_op_dispatch.go 91.11% 4 Missing ⚠️
shortcuts/sheets/flag_view.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2374      +/-   ##
==========================================
- Coverage   76.41%   76.26%   -0.15%     
==========================================
  Files        1047     1048       +1     
  Lines      115504   116992    +1488     
==========================================
+ Hits        88260    89224     +964     
- Misses      20443    20791     +348     
- Partials     6801     6977     +176     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

PR Quality Summary

CI did not complete successfully. Use the failed check links below to decide whether this PR needs a code change or a rerun.

Failed checks

var ranges []string
start := 0
inQuote := false
for i := 0; i <= len(value); i++ {
if err != nil {
return err
}
input, err := chartConfigUpdateInput(runtime, token, sheetID, sheetName)
if err != nil {
return err
}
input, err := chartDataUpdateInput(runtime, token, sheetID, sheetName)
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zhengzhijiej-tech
zhengzhijiej-tech force-pushed the feat-chart-opt-special-types-cli branch from 8affba5 to bc33415 Compare August 20, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/ccm PR touches the ccm domain size/XL Architecture-level or global-impact change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants