fix(lark-im): remove corner_radius from column in metric-card example - #2377
fix(lark-im): remove corner_radius from column in metric-card example#2377catcatcash wants to merge 1 commit into
Conversation
The style guide's section-3 example sets corner_radius on a column, but card 2.0's column does not support that property — any card built from the example is rejected at send time with 200621 unknown property. Remove it and note that rounded corners belong on interactive_container.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe KPI card documentation now identifies ChangesKPI card guidance
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized documentation correction removes an unsupported card property and clarifies the supported alternative; no actionable merge-blocking risk remains after normal checks and review. Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
logarithmone1128
left a comment
There was a problem hiding this comment.
Reviewed against the original 200621 reproduction and the card 2.0 component reference. This removes the unsupported column.corner_radius field while preserving the supported column styling, and the interactive_container guidance points to the correct rounded-corner alternative. This fully addresses the reported documentation defect.
修复 #2371。
lark-im-card-style.md第 3 节指标卡示例里,corner_radius写在了column上。卡片 2.0 的column不支持这个属性,照着示例发的卡片会被平台拒绝(200621 unknown property),错误只在发送时才暴露。改动两处:
column上的corner_radius(background_style/padding/vertical_spacing保留,这些合法)column不支持圆角,需要圆角的场景包一层interactive_container(第 4 节就是这个写法)纯文档改动,没动代码。
Summary by CodeRabbit