Skip to content

fix(lark-im): remove corner_radius from column in metric-card example - #2377

Open
catcatcash wants to merge 1 commit into
larksuite:mainfrom
catcatcash:fix/lark-im-card-style-column-corner-radius
Open

fix(lark-im): remove corner_radius from column in metric-card example#2377
catcatcash wants to merge 1 commit into
larksuite:mainfrom
catcatcash:fix/lark-im-card-style-column-corner-radius

Conversation

@catcatcash

@catcatcash catcatcash commented Aug 18, 2026

Copy link
Copy Markdown

修复 #2371

lark-im-card-style.md 第 3 节指标卡示例里,corner_radius 写在了 column 上。卡片 2.0 的 column 不支持这个属性,照着示例发的卡片会被平台拒绝(200621 unknown property),错误只在发送时才暴露。

改动两处:

  • 示例里删掉 column 上的 corner_radiusbackground_style / padding / vertical_spacing 保留,这些合法)
  • 加一行提醒:column 不支持圆角,需要圆角的场景包一层 interactive_container(第 4 节就是这个写法)

纯文档改动,没动代码。

Summary by CodeRabbit

  • Documentation
    • Clarified KPI card styling guidance for rounded corners.
    • Updated the KPI example to remove an unsupported setting and recommend the appropriate alternative.

The style guide's section-3 example sets corner_radius on a column,
but card 2.0's column does not support that property — any card built
from the example is rejected at send time with 200621 unknown property.
Remove it and note that rounded corners belong on interactive_container.
@github-actions github-actions Bot added domain/im PR touches the im domain size/M Single-domain feat or fix with limited business impact labels Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: db85c4b5-1427-4b66-8e8b-c3a8f0b8464b

📥 Commits

Reviewing files that changed from the base of the PR and between 9b231d9 and d068d3c.

📒 Files selected for processing (1)
  • skills/lark-im/references/card/lark-im-card-style.md

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The KPI card documentation now identifies column.corner_radius as unsupported, documents the resulting error, recommends interactive_container for rounded corners, and removes the property from the KPI example.

Changes

KPI card guidance

Layer / File(s) Summary
Correct column corner radius guidance
skills/lark-im/references/card/lark-im-card-style.md
The guidance warns that column.corner_radius causes error 200621 unknown property. The KPI example removes the unsupported property and recommends interactive_container for rounded corners.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d068d

This localized documentation correction removes an unsupported card property and clarifies the supported alternative; no actionable merge-blocking risk remains after normal checks and review.

Possibly related issues

  • larksuite/cli#2371 — The issue addresses the same corner_radius misuse on column.

Suggested reviewers: liangshuo-1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main documentation fix: removing the unsupported corner_radius property from the metric-card column example.
Description check ✅ Passed The description clearly explains the issue, scope, specific changes, affected error, and that this is a documentation-only change, although it does not use the repository template headings or include a test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@logarithmone1128 logarithmone1128 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against the original 200621 reproduction and the card 2.0 component reference. This removes the unsupported column.corner_radius field while preserving the supported column styling, and the interactive_container guidance points to the correct rounded-corner alternative. This fully addresses the reported documentation defect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/im PR touches the im domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants