refactor(testing): dispatch max-slot derivation with a match#1161
Merged
tcoratger merged 1 commit intoJun 18, 2026
Merged
Conversation
The key-slot scan filtered steps by isinstance and re-tested the type in a ternary. A local match tests each step type once and makes the two attestation cases explicit. Same slots, vectors byte-identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_resolved_max_slotfiltered steps byisinstanceand then re-tested the type in a ternary (aBlockStepwas filtered in and re-checked; the two attestation types shared a branch hidden in the ternary's else). Replaced with a localmatchthat tests each step type once and names the two attestation cases explicitly.Pure structural refactor —
maxover the same multiset of slots. Found in the packages/testing audit (FIXTURES-04).Lint:
ruff check+ruff formatclean.