Allow passthrough of sync_filter in deserialization and model validation logic#285
Merged
bjester merged 2 commits intolearningequality:release-v0.8.xfrom Feb 4, 2026
Conversation
…idation (clean) logic
de7b43e to
0042810
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
excludekwarg to*clean_fieldsmethods onSyncableModel, in parity with Django'sclean_fieldssync_filterkwarg to*clean_fieldsmethods onSyncableModelto support excluding fields based off the current sync filtersync_filterkwarg to deserialize methods onSyncableModelandStoreto allow passthrough from deserialization operation, and passes it through to*clean_fieldsmethodsTODO
Reviewer guidance
excludefor the*clean_fieldskwarg because it matches Django's kwargIssues addressed
closes #281