chore: apply dotnet format to match .editorconfig (#115)#1
Open
leecampbell-codeagent wants to merge 23 commits intomainfrom
Open
chore: apply dotnet format to match .editorconfig (#115)#1leecampbell-codeagent wants to merge 23 commits intomainfrom
leecampbell-codeagent wants to merge 23 commits intomainfrom
Conversation
* Harden devcontainer agent infrastructure Fix data loss on failed PR creation by backing up plan state and restoring on failure. Add prompt injection boundary around issue body content. Stop the agent loop on failure instead of continuing. Wire up TIMEOUT_SECONDS to CLAUDE_TIMEOUT. Parameterise upstream base branch. Fix pick-issue resume logic when plan state is missing. Add docker build step and nuget-cache volume to fleet.sh. Update .env.example to match actual env var usage.
Add .env to .gitignore to prevent committing secrets. Remove gh pr create from auto-allow and add git -C and cd to deny list in Claude Code settings to enforce sandbox boundaries. Co-authored-by: Claude Opus 4.6 <[email protected]>
* Modernize NuGet package metadata to fix NU5125 and NU5048 (HdrHistogram#107) Replace deprecated <PackageLicenseUrl> with <PackageLicenseExpression>CC0-1.0 OR BSD-2-Clause>, replace <PackageIconUrl> with <PackageIcon> (embedding the icon in the package), add <PackageReadmeFile> with README.md embedded, and add <WarningsAsErrors>NU5125;NU5048</WarningsAsErrors> to enforce these deprecations as build errors going forward. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * plan(HdrHistogram#107): initial brief from issue * plan(HdrHistogram#107): review brief * plan(HdrHistogram#107): create task breakdown * feat(HdrHistogram#107): implement tasks * feat(HdrHistogram#107): complete implementation --------- Co-authored-by: Claude Sonnet 4.6 <[email protected]>
* Fix CRLF line endings breaking devcontainer entrypoint on Linux Add .gitattributes to enforce LF endings for shell scripts, preventing the "no such file or directory" error when Docker runs entrypoint.sh on Linux after a Windows checkout converts line endings to CRLF. Co-Authored-By: Claude Opus 4.6 <[email protected]> * Add .env to .gitignore to prevent committing secrets Co-Authored-By: Claude Opus 4.6 <[email protected]> --------- Co-authored-by: Claude Opus 4.6 <[email protected]>
* plan(HdrHistogram#106): initial brief from issue * plan(HdrHistogram#106): review brief * plan(HdrHistogram#106): create task breakdown * feat(HdrHistogram#106): implement tasks * feat(HdrHistogram#106): complete implementation
…g project (HdrHistogram#113) * plan(HdrHistogram#105): initial brief from issue * plan(HdrHistogram#105): review brief * plan(HdrHistogram#105): apply brief review feedback * plan(HdrHistogram#105): review brief * plan(HdrHistogram#105): create task breakdown * feat(HdrHistogram#105): implement tasks * feat(HdrHistogram#105): complete implementation
…istogram#120) Build PR description from plan artifacts (brief.md and task.md) instead of posting them as separate comments. Append `Closes #N` so GitHub automatically closes the linked issue on merge. Co-authored-by: Claude Opus 4.6 <[email protected]>
…am#123) * plan(HdrHistogram#66): initial brief from issue * plan(HdrHistogram#66): review brief * plan(HdrHistogram#66): create task breakdown * feat(HdrHistogram#66): implement tasks * feat(HdrHistogram#66): complete implementation
…ions (HdrHistogram#124) * plan(HdrHistogram#114): initial brief from issue * plan(HdrHistogram#114): review brief * plan(HdrHistogram#114): create task breakdown * feat(HdrHistogram#114): implement tasks * feat(HdrHistogram#114): complete implementation
…s generated by Visual Studio (HdrHistogram#122) * plan(HdrHistogram#70): initial brief from issue * plan(HdrHistogram#70): review brief * plan(HdrHistogram#70): create task breakdown * fix(HdrHistogram#70): fix .gitignore IDE artefact exclusions - Replace spurious `.vs/ ` (trailing space) under `# VS Code` with `.vscode/` - Removes duplicate/misattributed `.vs/` entry - Adds missing VS Code workspace directory exclusion - Retains correct `.vs/` entry under `# Visual Studio cache/options directory` Co-Authored-By: Claude Sonnet 4.6 <[email protected]> * feat(HdrHistogram#70): implement tasks * feat(HdrHistogram#70): complete implementation --------- Co-authored-by: Claude Sonnet 4.6 <[email protected]>
…drHistogram#121) * feat: fleet.sh assigns issues to containers for parallel isolation fleet.sh now fetches available issues upfront and launches one container per issue with ISSUE_NUMBER env var, preventing duplicate work. agent-loop.sh pick-issue honours pre-assigned issue when set. Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix: address PR review feedback - Use GH_TOKEN_UPSTREAM for gh issue view in pre-assigned path - Use 'add // []' in jq merge to guard against null Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix: sort issues oldest-first in fleet.sh gh issue list defaults to newest-first. Add --search "sort:created-asc" so the fleet processes the oldest issues first. Co-Authored-By: Claude Opus 4.6 <[email protected]> --------- Co-authored-by: Claude Opus 4.6 <[email protected]>
Replace external jq calls with gh --jq flag and bash arrays. fleet.sh runs on the host where jq may not be installed (especially Windows). gh bundles its own jq implementation, so this eliminates the dependency while keeping the same issue-fetching and deduplication logic. Co-authored-by: Claude Opus 4.6 <[email protected]>
- Add sort:created-asc to agent-loop.sh issue self-selection to match fleet.sh behaviour (oldest issues first) - Add --output-format stream-json --verbose to run_claude() for structured output - Document cd/git -C avoidance in CLAUDE.md Co-authored-by: Claude Opus 4.6 <[email protected]>
…ettings (HdrHistogram#127) * plan(HdrHistogram#116): initial brief from issue * plan(HdrHistogram#116): review brief * plan(HdrHistogram#116): apply brief review feedback * plan(HdrHistogram#116): review brief * plan(HdrHistogram#116): create task breakdown * feat(HdrHistogram#116): implement tasks * feat(HdrHistogram#116): complete implementation
LeeCampbell
force-pushed
the
agent/115-run-dotnet-format-to-fix-existing-code-t
branch
from
2c6ecad to
0890835
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotnet format whitespace HdrHistogram.slnto bring all source files into alignment with the repository's.editorconfigrules.ENDOFLINE(line ending style)FINALNEWLINE(missing final newlines)CHARSET(file encoding/BOM)WHITESPACE(trailing/incorrect whitespace).git-blame-ignore-revsfile is included so that this bulk formatting commit can be skipped when usinggit blame, preserving meaningful authorship history.Closes HdrHistogram#115
Test plan
git blamecan use.git-blame-ignore-revsto skip the bulk commit:git blame --ignore-revs-file .git-blame-ignore-revs🤖 Generated with Claude Code