Repository navigation
🐛 Give each test its own LTO object for dsymutil - #59
Merged
Merged
Conversation
Apple's ld writes a fixed lto.o into the shared -object_path_lto directory, so parallel test links overwrite each other's object and dsymutil warns "could not find symbol". Point each test at its own object under CMakeFiles/<test>.dir/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Apple's
ld(llvm-toolchain#52),-object_path_lto,./makes every link write the same./lto.o. Test executables link in parallel, so dsymutil reads another test's object and prints hundreds ofcould not find symbol ... in object file .//lto.owarnings, leaving incomplete dSYMs.When generating dSYMs, each test now links with
-object_path_lto,CMakeFiles/<test>.dir/lto.o.Tested: libhal/v5 with
hal/tc/llvm-23on macOS 27. 309 warnings went to 0, and all tests pass.test_serial.dSYMnow contains debug info forserial_write_test.