Add signedPeerRecord and discussion of message sizes to identify#709
Open
achingbrain wants to merge 2 commits intomasterfrom
Open
Add signedPeerRecord and discussion of message sizes to identify#709achingbrain wants to merge 2 commits intomasterfrom
achingbrain wants to merge 2 commits intomasterfrom
Conversation
Adds the missing `signedPeerRecord` field and an implementation notes section to discuss max message sizes and how to send/receive multiple identify messages during one transaction.
MarcoPolo
approved these changes
Apr 8, 2026
dennis-tra
reviewed
Apr 9, 2026
Co-authored-by: Dennis Trautwein <[email protected]>
wjmelements
reviewed
Apr 15, 2026
| should break it up into smaller chunks. | ||
|
|
||
| For optimum backwards compatibility the first message SHOULD NOT exceed 2KB. | ||
| Subsequent messages SHOULD NOT exceed 4KB. |
There was a problem hiding this comment.
Can signed peer records be subdivided? I suspect they can themselves exceed 4 KB.
There was a problem hiding this comment.
One possible issue is signature size of signed peer records if/when libp2p supports post quantum signatures - 4KB would be too small for ML-DSA-44 and ML-DSA-65, 8KB would be too small for ML-DSA-87
| Variant | Public key (bytes) | Signature (bytes) |
| --- | ---: | ---: | ---: |
| ML-DSA-44 | 1312 | 2420 |
| ML-DSA-65 | 1952 | 3309 |
| ML-DSA-87 | 2592 | 4627 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing
signedPeerRecordfield and an implementation notes section to discuss max message sizes and how to send/receive multiple identify messages during one transaction.Also updates the language around receiving messages to make it clear that multiple messages may be sent.