Libretro fixes - #128
Open
sasq64 wants to merge 3 commits into
Open
Conversation
retro_init() returned early from the branch that passes --tos to Main_Init(), so whenever a system directory (and thus a TOS image) was found — the normal case — Core_ApplyBootOptions() was never reached and none of the core options had any effect. Turn the early return into an else branch so both paths fall through to it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXACgnzMXVboN9tWyZuu5F
… after Core_ApplyBootOptions() used to run in retro_init() after Main_Init() had already built the machine, so it had to force a reconfigure+cold reset to make machine/CPU/memory/ROM options take effect. Rename it to Core_SetBootOptions() and call it from Main_Init() itself, right after the config file and command line are read but before anything is built from them, so the machine comes up correctly configured the first time. Also fix the CoreRetro static library target missing libretro.h include path, needed now that main.c pulls in retro/options.h. Generated with Claude Code
Screen_Init() was capping the display at exactly 320x200, the ST screen's own size, so ConvST_SetSTResolution() never had any border pixels left to draw and the hatari_borders core option was a no-op. Raise the cap to the full 416x276 visible area (still below 640x400 so low res doesn't get doubled, which is the frontend's job). Also call Screen_ModeChanged() after Core_ApplyRuntimeOptions() applies the config, so a changed border/monitor/aspect option takes effect immediately instead of waiting for the emulated program to switch resolution on its own. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Collaborator
|
We are not accepting AI contributions at this time, as this project is trying to get the core merged into hatari upstream but I will look at those fixes. Thanks ! |
Collaborator
|
@sasq64 I have gone through the code and made additions/changes where required. Should be on the buildbot in the next few hours |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are claude assisted fixes that I needed to make the libretro build work;
If you don't accept AI code then just see this PR as documentation.