vector: mask supported Highway targets by builtin targets #4816
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure `vips_vector_get_supported_targets()` only reports targets that were actually compiled into libvips by intersecting the CPU supported targets with the builtin targets. Resolves: libvips#4815.
Member
Author
|
For reference, tested using: $ podman run --rm -it --platform=linux/s390x -e QEMU_CPU=max fedora:latest
$ dnf install gcc-c++ meson git glib2-devel expat-devel highway-devel
$ git clone -b issue-4815 https://github.com/kleisauke/libvips.git
$ cd libvips
$ meson setup build --prefix=/usr -D{deprecated,examples}=false
$ meson compile -C build
$ meson install -C build
$ vips --targets
builtin targets: SCALAR
supported targets: none |
jcupitt
approved these changes
Dec 19, 2025
|
And actually this PR fixes https://bugzilla.redhat.com/show_bug.cgi?id=2421762 . 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
vips_vector_get_supported_targets()only reports targets that were actually compiled into libvips by intersecting the CPU supported targets with the builtin targets.Resolves: #4815.