fix Dockerfile, several plugins running#599
Open
iorch wants to merge 3 commits intolightningd:masterfrom
Open
Conversation
Collaborator
|
Waiting on #584 as the mutinynet and testnet examples are dependent on mempool.space support |
Contributor
|
Hey, I tried it out and I ran into this error: |
Contributor
|
@chrisguida mempool.space support should be working now. |
Contributor
|
@iorch I tried it again with the new docker image you sent me and I got this error message: also, @chrisguida noticed this: It's installing plugins that are already archived, and it shouldn't. |
Collaborator
|
Thinking about this more, I think the best way for us to implement this may be just to reuse the plugin installation code from the CI see https://github.com/lightningd/plugins/blob/master/.ci/test.py for the code that installs the python dependencies That way all of the plugins should work |
Collaborator
|
@iorch are you still working on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #547
https://github.com/iorch/plugins/blob/issue-547/README.md#docker
@chrisguida