-
Notifications
You must be signed in to change notification settings - Fork 445
RBF splice funding transactions #4427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jkczyz
wants to merge
35
commits into
lightningdevkit:main
Choose a base branch
from
jkczyz:2026-02-splicing-rbf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,427
−203
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
953ac60
Accept tx_init_rbf for pending splice transactions
jkczyz 78619be
f - Also check sent_funding_txid in validate_tx_init_rbf
jkczyz b99dd74
f - Remove redundant holder_is_quiescence_initiator field
jkczyz f34d9f8
f - Remove unnecessary debug_assert in internal_tx_init_rbf
jkczyz 0097459
f - DRY up splice_init and tx_init_rbf acceptor paths
jkczyz e276b42
f - Use last negotiated candidate in validate_tx_init_rbf
jkczyz 74a8b1b
f - Use ChannelError::Abort for negotiation rejections in validate_tx…
jkczyz 9bc7257
Allow multiple RBF splice candidates in channel monitor
jkczyz 90b44f2
f - Document dual-funded channel locking property in comment
jkczyz d2dd300
Add rbf_channel API for initiating splice RBF
jkczyz cbacc68
f - Also check received_funding_txid in can_initiate_rbf
jkczyz 3d8fb40
Send tx_init_rbf instead of splice_init when a splice is pending
jkczyz 90aa3f5
Handle tx_ack_rbf on the initiator side
jkczyz 8ab8917
f - Extract awaiting_ack_context and begin_funding_negotiation helpers
jkczyz 3c849b6
f - Replace begin_funding_negotiation with FundingNegotiation::for_in…
jkczyz e19793e
f - Use specific expect messages in tx_ack_rbf and splice_ack
jkczyz f51e1fa
f - Add test_splice_rbf_not_quiescence_initiator test
jkczyz 03fa24e
f - Update test_splice_rbf_not_quiescence_initiator to expect tx_abort
jkczyz 149346c
f - Remove unnecessary debug_assert in internal_tx_ack_rbf
jkczyz 3931402
f - Use last negotiated candidate in validate_tx_ack_rbf
jkczyz d67118b
Allow acceptor contribution to RBF splice via tx_init_rbf
jkczyz 4e4f00e
f - DRY up lock_rbf_splice_after_blocks by reusing lock_splice
jkczyz e1cf62a
f - Clean up discarded funding watches in lock_splice
jkczyz 6fe4c54
Preserve our funding contribution across counterparty RBF attempts
jkczyz 20594f2
f - Remove redundant debug_assert in send_tx_init_rbf path
jkczyz 8054570
f - Use ChannelError::Abort for prior contribution failures in tx_ini…
jkczyz 30c9b5a
f - Remove redundant manual cleanup from splicing tests
jkczyz 9c2f382
Consider prior contributions when filtering unique inputs/outputs
jkczyz 6d9276f
Filter prior contributions from SpliceFundingFailed events
jkczyz b52a2b5
f - Compare script_pubkey instead of entire TxOut when filtering outputs
jkczyz e48133e
Handle FeeRateAdjustmentError variants in splice acceptor path
jkczyz 743630e
f - Simplify FeeRateAdjustmentError match by moving suffixes into Dis…
jkczyz f662eea
f - Use ChannelError::Abort for FeeRateTooHigh in resolve_queued_cont…
jkczyz d51dbd0
f - test rejecting RBF when fee rate is too high
jkczyz e9cbe71
f - Update test_splice_rbf_tiebreak_feerate_too_high_rejected to expe…
jkczyz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.