cmd/loop: drop misleading static loop-in fee warning

[hieblmi]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up the user interface by removing a potentially confusing warning message regarding on-chain fees for static address loop-ins. The changes ensure that the command output is more concise and accurate, while also updating the documentation and adding a test to prevent regressions.

Highlights

• Removed misleading warning: Removed the static loop-in fee warning message from the command line output as it was deemed misleading.
• Updated documentation: Updated the regtest README to reflect the removal of the fee warning message in the command output examples.
• Added regression test: Introduced a new test case to verify that the fee warning message is no longer displayed during static loop-in operations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes redundant informational messages regarding on-chain fees for static address loop-ins from the CLI output and updates the documentation to match. It also introduces a new test suite to verify the display logic. Feedback was provided to improve the test's resource management by ensuring all pipe writers are closed within the cleanup function to prevent potential leaks or hangs.

[starius]

LGTM! 💯

[starius]

Do we really need a test for this specific change? We don't have CLI tests overall yet. When #1072 is ready, we can just add it there as a recorded session.

[hieblmi]

Removed it.