docs: quickstart improvements#59
Open
cdebled wants to merge 2 commits into
Open
Conversation
The default npm init uses commonjs which breaks the ESM import syntax used in the example script. Switch to npm init -y and explicitly set type=module, with a package.json snippet to confirm the setup.
krichprollsch
approved these changes
Apr 13, 2026
| cd hn-scraper && \ | ||
| npm init | ||
| npm init -y && \ | ||
| npm pkg set type=module |
Member
There was a problem hiding this comment.
Alternatively we could replace all .js extensions with .mjs which AFAIK run correctly w/ default nodejs config.
But idk what is the best practice TBH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm init -ywithtype=modulein quickstart to avoid ES module errors