Skip to content

Extract closed PR #723 commits into develop #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashleyshaw merged 2 commits into from
Jun 1, 2026
Merged

Extract closed PR #723 commits into develop #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e783527
chore: Extract closed PR #723 commits to develop
claude Jun 1, 2026
1c50c05
docs: clarify that protected branch restrictions apply to direct pushes
claude Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/issue-types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ issue_types:
- name: Support
color: 0E8A16
label: type:support
- name: Help
color: 0E8A16
label: type:help
- name: User Experience Feedback
color: "5319E7"
label: type:ux-feedback
- name: Help
color: 0E8A16
label: type:help
Comment on lines 88 to +91
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add canonical labels for new issue types

In the labeling workflow (.github/workflows/labeling.yml lines 83-86), check-template-labels.js treats every label referenced by .github/issue-types.yml as required in .github/labels.yml. These new issue types introduce type:ux-feedback and type:help, but those labels are not defined in .github/labels.yml; running node scripts/agents/includes/check-template-labels.js now fails with both labels as unknown. This will fail the unified labeling workflow for develop pushes, PRs, issues and discussions until the matching canonical labels are added or the mappings are changed to existing labels.

Useful? React with 👍 / 👎.

52 changes: 50 additions & 2 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
title: "LightSpeed .github — Claude Instructions"
description: "Claude-specific project instructions for the LightSpeed .github repository."
version: 'v1.2'
last_updated: '2026-06-01'
version: "v1.2"
last_updated: "2026-06-01"
file_type: "agents-index"
maintainer: "LightSpeed Team"
---
Expand Down Expand Up @@ -40,6 +40,54 @@ It also hosts **portable AI operations assets** in top-level source folders that

Do **not** place reusable assets under `.github/`—use the matching top-level folder instead.

## Git & Branching Strategy

> **CRITICAL:** This repository follows a strict branching discipline. Read [docs/BRANCHING_STRATEGY.md](./docs/BRANCHING_STRATEGY.md) before opening any PR.

### Protected Branches

- `main` is **always production-ready**. Never push directly to `main` unless performing a **release cycle**.
- `develop` (if used) is an integration branch. Never push directly to `develop` outside release/hotfix workflows.
- All other work goes to feature/fix/chore branches.

### Branch Naming Convention

Use the format: `{type}/{scope}-{short-title}` (lowercase, kebab-case)

**Common prefixes:**

- `feat/` — new feature or capability
- `fix/` — bug fix
- `hotfix/` — urgent production fix (branches from `main`)
- `chore/` — maintenance, refactoring, dependency updates
- `docs/` — documentation changes
- `ci/` — CI/CD workflow changes
- `test/` — test-only changes
- `refactor/` — code restructure
- `security/` — security fixes

**Examples:**

```
chore/readme-frontmatter-standardization
fix/invalid-branch-name-validation
docs/update-contributing-guide
release/v1.2.0
```

**Branch protection enforcement:**

- All PRs require branch names matching the regex pattern
- CI will block misnamed branches from merging
- Rename with `git branch -m <old> <new>` if needed

### Before Every Push

1. Verify the current branch: `git branch -v`
2. Confirm it is NOT `main` or `develop` (unless in a release cycle)
3. Ensure the branch name follows the `{type}/{scope}-{short-title}` pattern
4. Use: `git push -u origin <branch-name>`

## Development Commands

```bash
Expand Down
Loading