-
Notifications
You must be signed in to change notification settings - Fork 86
Adding create channel api changes to python SDK #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mawasthy-lgtm
wants to merge
7
commits into
linode:dev
Choose a base branch
from
mawasthy-lgtm:feat/add-create-alert-channel
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f4ab4af
adding create channel api changes
mawasthy-lgtm d33a714
adding delete and update channel changes
mawasthy-lgtm 54d4efc
fixing test case to not hardcode usernames
mawasthy-lgtm 21ef5c1
updating review comment fixes
mawasthy-lgtm b7d0367
adding sdk support for get channel endpoints
mawasthy-lgtm d2de2ef
Resolve merge conflicts with upstream dev
mawasthy-lgtm 98ba868
resolving review comments
mawasthy-lgtm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "id": 123, | ||
| "label": "alert notification channel", | ||
| "type": "user", | ||
| "channel_type": "email", | ||
| "details": { | ||
| "email": { | ||
| "usernames": [ | ||
| "admin-user1", | ||
| "admin-user2" | ||
| ], | ||
| "recipient_type": "user" | ||
| } | ||
| }, | ||
| "alerts": { | ||
| "url": "/monitor/alert-channels/123/alerts", | ||
| "type": "alerts-definitions", | ||
| "alert_count": 2 | ||
| }, | ||
| "created": "2024-01-01T00:00:00", | ||
| "updated": "2024-01-01T00:00:00", | ||
| "created_by": "tester", | ||
| "updated_by": "tester" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "data": [ | ||
| { | ||
| "id": 12345, | ||
| "label": "DBAAS Alert 1", | ||
| "service_type": "dbaas", | ||
| "type": "alerts-definitions", | ||
| "url": "/monitor/services/dbaas/alerts-definitions/12345" | ||
| }, | ||
| { | ||
| "id": 12346, | ||
| "label": "DBAAS Alert 2", | ||
| "service_type": "dbaas", | ||
| "type": "alerts-definitions", | ||
| "url": "/monitor/services/dbaas/alerts-definitions/12346" | ||
| } | ||
| ], | ||
| "page": 1, | ||
| "pages": 1, | ||
| "results": 2 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,7 +41,7 @@ | |
| "metric": "cpu_usage", | ||
| "operator": "gt", | ||
| "threshold": 90, | ||
| "unit": "percent" | ||
| "unit": "%" | ||
| } | ||
| ] | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ | |
| "metric": "cpu_usage", | ||
| "operator": "gt", | ||
| "threshold": 90, | ||
| "unit": "percent" | ||
| "unit": "%" | ||
| } | ||
| ] | ||
| }, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.