Skip to content

TPT-4256: Implemented changes for SLADE and CLEO projects#910

Open
ezilber-akamai wants to merge 3 commits intolinode:proj/slade-cleofrom
ezilber-akamai:TPT-4256-slade-cleo
Open

TPT-4256: Implemented changes for SLADE and CLEO projects#910
ezilber-akamai wants to merge 3 commits intolinode:proj/slade-cleofrom
ezilber-akamai:TPT-4256-slade-cleo

Conversation

@ezilber-akamai
Copy link
Copy Markdown
Contributor

@ezilber-akamai ezilber-akamai commented Mar 9, 2026

📝 Description

Added new kernel and boot_size fields to Linode Create options. Also added a notice that one of root_pass authorized_users, or authorized_keys is required when image is provided rather than just requiring root_pass.

✔️ How to Test

make test-unit

Copilot AI review requested due to automatic review settings March 9, 2026 19:11
@ezilber-akamai ezilber-akamai requested a review from a team as a code owner March 9, 2026 19:11
@ezilber-akamai ezilber-akamai added breaking-change for breaking changes in the changelog. new-feature for new features in the changelog. labels Mar 9, 2026
@ezilber-akamai ezilber-akamai requested review from ckulinsk and lgarber-akamai and removed request for a team March 9, 2026 19:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Linode instance/disk create request models to support new SLADE/CLEO-related fields and to allow omitting root_pass by switching it to a pointer type.

Changes:

  • Add kernel and boot_size to InstanceCreateOptions.
  • Change root_pass from string to *string for Instance create/rebuild and Disk create options (breaking change).
  • Update unit/integration tests to use linodego.Pointer(...) for the new pointer-based RootPass fields.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
instances.go Makes RootPass optional via *string; adds Kernel and BootSize to instance create options.
instance_disks.go Makes disk-create RootPass optional via *string.
test/unit/instance_test.go Updates unit tests for instance create/rebuild to use pointer-based RootPass; adds coverage for new fields in the options struct.
test/unit/instance_disks_test.go Updates unit test for disk create to use pointer-based RootPass.
test/integration/instances_test.go Updates integration tests to use pointer-based RootPass in instance/disk workflows.
test/integration/instance_reserved_ips_test.go Updates integration tests to use pointer-based RootPass when creating instances.
test/integration/instance_interfaces_test.go Updates integration helper to use pointer-based RootPass.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ezilber-akamai ezilber-akamai removed the breaking-change for breaking changes in the changelog. label Mar 10, 2026
@ezilber-akamai ezilber-akamai changed the title Implemented changes for SLADE and CLEO projects TPT-4256: Implemented changes for SLADE and CLEO projects Mar 11, 2026
@ezilber-akamai ezilber-akamai marked this pull request as draft March 12, 2026 15:33
@ezilber-akamai ezilber-akamai marked this pull request as ready for review March 17, 2026 15:43
Copy link
Copy Markdown
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants