Skip to content

blk-cgroup: fix disk reference leak in blkcg_maybe_throttle_current()#709

Open
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
series/1075055=>linus-master
Open

blk-cgroup: fix disk reference leak in blkcg_maybe_throttle_current()#709
blktests-ci[bot] wants to merge 1 commit intolinus-master_basefrom
series/1075055=>linus-master

Conversation

@blktests-ci
Copy link
Copy Markdown

@blktests-ci blktests-ci bot commented Mar 31, 2026

Pull request for series with
subject: blk-cgroup: fix disk reference leak in blkcg_maybe_throttle_current()
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1075055

@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Mar 31, 2026

Upstream branch: 7aaa804
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from c781e1e to 255b4bf Compare March 31, 2026 12:54
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Mar 31, 2026

Upstream branch: d0c3bcd
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1075055=>linus-master branch from a8744b3 to 79d2c0f Compare March 31, 2026 13:04
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Mar 31, 2026

Upstream branch: d0c3bcd
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1075055=>linus-master branch from 79d2c0f to 00bac35 Compare March 31, 2026 15:37
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Mar 31, 2026

Upstream branch: d0c3bcd
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1075055=>linus-master branch from 00bac35 to cb873bb Compare March 31, 2026 19:20
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 255b4bf to 3236861 Compare April 1, 2026 02:20
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Apr 1, 2026

Upstream branch: 9147566
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1075055=>linus-master branch from cb873bb to 0107a7f Compare April 1, 2026 02:29
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch 2 times, most recently from ecbdbb4 to 480b162 Compare April 2, 2026 07:52
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Apr 2, 2026

Upstream branch: 9147566
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1075055=>linus-master branch from 0107a7f to 9048efe Compare April 2, 2026 07:59
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch 2 times, most recently from a96fba7 to 0cd6ac2 Compare April 3, 2026 07:51
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Apr 3, 2026

Upstream branch: 9147566
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1075055=>linus-master branch from 9048efe to 303f96d Compare April 3, 2026 07:59
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 0cd6ac2 to 910d344 Compare April 3, 2026 11:53
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Apr 3, 2026

Upstream branch: d8a9a4b
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1075055=>linus-master branch from 303f96d to a220e45 Compare April 3, 2026 12:01
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 910d344 to ed862bc Compare April 4, 2026 05:34
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Apr 4, 2026

Upstream branch: 7ca6d1c
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1075055=>linus-master branch from a220e45 to 8e93348 Compare April 4, 2026 05:43
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from ed862bc to 2d0c3d5 Compare April 4, 2026 16:55
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Apr 4, 2026

Upstream branch: 3aae938
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1075055=>linus-master branch from 8e93348 to 3ad2a72 Compare April 4, 2026 17:03
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 2d0c3d5 to 931d9b0 Compare April 8, 2026 10:29
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Apr 8, 2026

Upstream branch: 3036cd0
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1075055=>linus-master branch from 3ad2a72 to 15eacad Compare April 8, 2026 10:40
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 931d9b0 to 78a4682 Compare April 10, 2026 00:51
@JackieLiu1 @kawasaki
blk-cgroup: fix disk reference leak in blkcg_maybe_throttle_current()
0165191 
Add the missing put_disk() on the error path in
blkcg_maybe_throttle_current(). When blkcg lookup, blkg lookup, or
blkg_tryget() fails, the function jumps to the out label which only
calls rcu_read_unlock() but does not release the disk reference acquired
by blkcg_schedule_throttle() via get_device(). Since current->throttle_disk
is already set to NULL before the lookup, blkcg_exit() cannot release
this reference either, causing the disk to never be freed.

Restore the reference release that was present as blk_put_queue() in the
original code but was inadvertently dropped during the conversion from
request_queue to gendisk.

Fixes: f05837e ("blk-cgroup: store a gendisk to throttle in struct task_struct")
Signed-off-by: Jackie Liu <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Acked-by: Tejun Heo <[email protected]>
@blktests-ci
Copy link
Copy Markdown
Author

blktests-ci bot commented Apr 10, 2026

Upstream branch: 9a9c8ce
series: https://patchwork.kernel.org/project/linux-block/list/?series=1075055
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1075055=>linus-master branch from 15eacad to 0165191 Compare April 10, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

linus-master new V1-ci-fail V1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@faraz-talebpour_AlfaITG @JackieLiu1