xfs: fix number of GC bvecs#728
Open
blktests-ci[bot] wants to merge 5 commits intolinus-master_basefrom
Open
Conversation
Author
|
Upstream branch: 3aae938 |
Author
|
Upstream branch: 3aae938 |
blktests-ci
bot
force-pushed
the
series/1078183=>linus-master
branch
from
40adf33 to
0bc215f
Compare
Author
|
Upstream branch: 3aae938 |
blktests-ci
bot
force-pushed
the
series/1078183=>linus-master
branch
from
0bc215f to
002edd0
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
2d0c3d5 to
931d9b0
Compare
Author
|
Upstream branch: 3036cd0 |
1 similar comment
Author
|
Upstream branch: 3036cd0 |
blktests-ci
bot
force-pushed
the
series/1078183=>linus-master
branch
from
002edd0 to
ff4a748
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
931d9b0 to
78a4682
Compare
added 5 commits
April 10, 2026 09:52
GC scratch allocations can wrap around and use the same buffer twice, and the current code fails to account for that. So far this worked due to rounding in the block layer, but changes to the bio allocator drop the over-provisioning and generic/256 or generic/361 will now usually fail when running against the current block tree. Simplify the allocation to always pass the maximum value that is easier to verify, as a saving of up to one bvec per allocation isn't worth the effort to verify a complicated calculated value. Fixes: 102f444 ("xfs: rework zone GC buffer management") Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Hans Holmberg <hans.holmberg@wdc.com>
Put the bio in bio_await_chain after waiting for the completion, and share the now identical callbacks between submit_bio_wait and bio_await_chain. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Add a new helper to wait for a bio and anything chained off it to complete synchronously after submitting it. This factors common code out of submit_bio_wait and bio_await_chain and will also be useful for file system code and thus is exported. Note that this will now set REQ_SYNC also for the bio_await case for consistency. Nothing should look at the flag in the end_io handler, but if something does having the flag set makes more sense. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Factor the common logic for the ioctl helpers to either submit a bio or end if the process is being killed. As this is now the only user of bio_await_chain, open code that. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Replace the open-coded bio wait logic with the new bio_await helper. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Author
|
Upstream branch: 9a9c8ce |
blktests-ci
bot
force-pushed
the
series/1078183=>linus-master
branch
from
ff4a748 to
24a5ec8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: xfs: fix number of GC bvecs
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1078183