Skip to content

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#104

Merged
richm merged 1 commit intomainfrom
ci-container-improvements
Mar 11, 2026
Merged

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#104
richm merged 1 commit intomainfrom
ci-container-improvements

Conversation

@richm
Copy link
Contributor

@richm richm commented Mar 11, 2026

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson [email protected]

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 test scenarios, improving container test behavior and performance.

CI:

  • Bump tox-lsr version from 3.16.0 to 3.17.0 across GitHub Actions workflows.
  • Run Fedora 43 qemu and container tests with Ansible 2.20 instead of 2.19.
  • Adjust container test environment variables to run full setup once and skip requirements and callback plugins on subsequent tests for faster execution.

…r fedora 43 [citest_skip]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson <[email protected]>
@richm richm requested a review from spetrosi as a code owner March 11, 2026 00:19
@richm richm self-assigned this Mar 11, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 11, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43, and refines container test execution behavior for faster, cleaner runs.

Flow diagram for ansible_lint workflow with tox_lsr_3_17_0

flowchart TD
  A["Workflow dispatch or PR event"] --> B["Checkout repository"]
  B --> C["Set up Python 3"]
  C --> D["Install tox and tox_lsr 3_17_0 using pip3"]
  D --> E["Convert role to collection format (tox_lsr task)"]
  E --> F["Run ansible_lint via tox_lsr"]
  F --> G{"Lint successful?"}
  G -->|Yes| H["Mark workflow as success"]
  G -->|No| I["Mark workflow as failed and expose improved container test output"]

  classDef start_end fill:#e8f5e9,stroke:#2e7d32,stroke-width:1px;
  classDef action fill:#e3f2fd,stroke:#1565c0,stroke-width:1px;
  classDef decision fill:#fff3e0,stroke:#ef6c00,stroke-width:1px;

  class A,H,I start_end;
  class B,C,D,E,F action;
  class G decision;
Loading

File-Level Changes

Change Details Files
Bump Ansible version for Fedora 43 qemu and container scenarios to 2.20.
  • Update Fedora 43 qemu test matrix to use the qemu-ansible-core-2-20 environment.
  • Update Fedora 43 container test matrix to use the container-ansible-core-2-20 environment.
  • Update Fedora 43 bootc container test matrix to use the container-ansible-core-2-20 environment.
.github/workflows/qemu-kvm-integration-tests.yml
Upgrade tox-lsr from 3.16.0 to 3.17.0 across CI workflows.
  • Update tox-lsr version in qemu-kvm integration workflow installation step.
  • Update tox-lsr version in ansible-lint workflow installation step.
  • Update tox-lsr version in ansible-managed-var-comment workflow installation step.
  • Update tox-lsr version in ansible-test workflow installation step.
  • Update tox-lsr version in python-unit-test workflow installation step.
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/python-unit-test.yml
Adjust container test runner behavior to leverage new tox-lsr capabilities and speed up subsequent runs.
  • Remove previous container debug/profile-related environment variable overrides.
  • Introduce SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS flags, forcing them off for the first test run.
  • Enable SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS after each test run to skip repeated setup on subsequent runs.
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit b4fd149 into main Mar 11, 2026
14 checks passed
@richm richm deleted the ci-container-improvements branch March 11, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant