chore(openai): remove dead VertexModels type alias - #7223
Merged
chenghao-mou merged 1 commit intoSep 11, 2026
Merged
chenghao-mou merged 1 commit into
chenghao-mou merged 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
chenghao-mou
approved these changes
Sep 11, 2026
chenghao-mou
deleted the
detail/dead-code/chore-openai-remove-dead-vertexmodels-type-alias-41c4ce
branch
September 11, 2026 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the unused
VertexModelsLiteral type alias from the OpenAI plugin'smodels.py. It had zero references anywhere in the codebase (no imports, typeannotations, tests, or
__all__re-exports).Its only consumer, the
LLM.with_vertex()static factory method, wasdeliberately removed in commit 4c372d2 ("Update llm.py"), which also dropped
the
VertexModelsimport fromllm.py. The Vertex/Gemini feature wassuperseded by the dedicated
google.LLM()plugin (PR #1382), leaving this typealias orphaned as a leftover from a removed feature.
History
google/gemini-2.0-flash-expas default model for vertex #1214 @jayeshp19)Dead Code PRs can be configured here.