Skip to content

Fix custom RTCConfigurations not picking up server-provided ice servers when needed - #993

Merged
davidliu merged 1 commit into
mainfrom
dl/fix_custom_rtcconfig
Aug 5, 2026
Merged

Fix custom RTCConfigurations not picking up server-provided ice servers when needed#993
davidliu merged 1 commit into
mainfrom
dl/fix_custom_rtcconfig

Conversation

@davidliu

@davidliu davidliu commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

A previous variable name change of an outer variable caused the inner apply scope code to refer to the RTCConfiguration's iceServer list (which was empty in this if branch), and not to the server-provided ice servers.

@changeset-bot

changeset-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 706d0f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
client-sdk-android Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Diffuse output:

OLD: diffuse-source-file
NEW: livekit-android-sdk-release.aar

 AAR      │ old      │ new      │ diff   
──────────┼──────────┼──────────┼────────
      jar │  2.7 MiB │  2.7 MiB │ -104 B 
 manifest │  1.5 KiB │  1.5 KiB │    0 B 
 lint-jar │ 12.7 KiB │ 12.7 KiB │    0 B 
    other │  1.9 KiB │  1.9 KiB │    0 B 
──────────┼──────────┼──────────┼────────
    total │  2.7 MiB │  2.7 MiB │ -104 B 

 JAR     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
 classes │  1510 │  1510 │ 0 (+0 -0) 
 methods │ 20253 │ 20253 │ 0 (+0 -0) 
  fields │  5202 │  5202 │ 0 (+0 -0)
AAR
 size    │ diff   │ path          
─────────┼────────┼───────────────
 2.7 MiB │ -104 B │ ∆ classes.jar 
─────────┼────────┼───────────────
 2.7 MiB │ -104 B │ (total)

@MaxHeimbrock MaxHeimbrock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidliu
davidliu merged commit bad05f0 into main Aug 5, 2026
6 checks passed
@davidliu
davidliu deleted the dl/fix_custom_rtcconfig branch August 5, 2026 03:46
@davidliu davidliu mentioned this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants