Conversation
This reverts commit 5c96762.
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
it is hard to look at the results and know that they are correct. I need to look at an entry in OUT_DTID and make sure it is at the correct index. I then need to go to OUT_GTID and determine the correct value for the DTID in the first array. Then I need to go to a third.
It would be nice to have all of the related information together with appropriate comments to explain the results.
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
I think the substance of the test looks good, but the comments don't seem correct.
|
There is a single CI failure I'm trying to debug hence the magic numbers in the last commit |
Keenuts
added
the
test-all
|
All test failures are now unrelated. PTAL |
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
I think the comments could be clearer, but I don't think it is a big deal. LGTM.
| # Dispatch: the dispatch coordinates in the 3D grid. | ||
| # thread: the thread coordinates in the thread group. | ||
| # | ||
| # Dispatch x=0 y=0 z=0 | thread x=0 y=0 z=0 |
There was a problem hiding this comment.
The dispatch is just the Group id, and the thread is group thread id.
2 participants
Add testing for compute shader system semantics on a 2x2x2 dispatch.