feat(config): add LogDir and move diagnostic logs to XDG state#192
Open
jcnnll wants to merge 1 commit intolocalstack:mainfrom
Open
feat(config): add LogDir and move diagnostic logs to XDG state#192jcnnll wants to merge 1 commit intolocalstack:mainfrom
jcnnll wants to merge 1 commit intolocalstack:mainfrom
Conversation
- Add LogDir() to resolve to XDG and Windows standard logging paths - Decoupled logging from configuration - Updated CLAUDE.md to follow the logging standard - Added integration test to cover this feature
jcnnll
requested review from
anisaoshafi,
carole-lavillonniere and
silv-io
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Member
|
Thanks for contributing, @jcnnll! ❤️ Heads-up: The team is sorting out a contribution policy process for this repository, we will follow up here as soon as we have clarity on next steps. Thanks for your patience. ⏳ |
Author
|
Thanks @gtsiolis for responding to this PR, I totally understand the situation and look forward to being able to contribute as an when the policy has been clarified in terms of community contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problemn Being Solved
Diagnostic logs are currently written to the user's configuration directory (~/.config/lstk). This mixes persistent configuration with diagnostic state, which clutters the config tree and doesn't follow standard OS conventions for logs.
Changes
Tests