Skip to content

Stream lstk logs lines to real terminal scrollback - #418

Merged
anisaoshafi merged 1 commit into
mainfrom
devx-1027-interactive-lstk-logs-does-not-preserve-scrollback
Jul 30, 2026
Merged

Stream lstk logs lines to real terminal scrollback#418
anisaoshafi merged 1 commit into
mainfrom
devx-1027-interactive-lstk-logs-does-not-preserve-scrollback

Conversation

@anisaoshafi

Copy link
Copy Markdown
Collaborator
  • Interactive lstk logs capped history at 200 lines and repainted it in place, so terminal scrollback stopped growing past that point (unlike docker logs / --non-interactive).
  • LogLineEvent now prints permanently above the TUI via a new output.NewStreamingLogSink + Program.Println, bypassing the capped buffer.
  • Printed synchronously (not via tea.Cmd) to keep lines in order — Bubble Tea runs returned Cmds concurrently, which reordered lines in an earlier pass.

Test plan

  • Unit tests for the new sink
  • New integration test: 550 lines on a real container, lstk logs under a real PTY, all survive in order
  • make test + make lint clean
  • Manually verified against a real emulator (600 lines, real PTY)
  • --non-interactive unchanged

Closes DEVX-1027

@anisaoshafi anisaoshafi added semver: patch docs: skip Pull request does not require documentation changes labels Jul 29, 2026
@anisaoshafi
anisaoshafi force-pushed the devx-1027-interactive-lstk-logs-does-not-preserve-scrollback branch from f18fe34 to 4d0c7c1 Compare July 29, 2026 17:02
@anisaoshafi
anisaoshafi force-pushed the devx-1027-interactive-lstk-logs-does-not-preserve-scrollback branch from 4d0c7c1 to e92edc1 Compare July 29, 2026 17:36
@anisaoshafi
anisaoshafi marked this pull request as ready for review July 29, 2026 17:43
@anisaoshafi
anisaoshafi requested a review from a team as a code owner July 29, 2026 17:43

@skyrpex skyrpex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, now the lstk logs command is really useful 👍🏻

@anisaoshafi
anisaoshafi merged commit 5fecadc into main Jul 30, 2026
19 checks passed
@anisaoshafi
anisaoshafi deleted the devx-1027-interactive-lstk-logs-does-not-preserve-scrollback branch July 30, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs: skip Pull request does not require documentation changes semver: patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants