Repository navigation
Selectively skip test that only passes for dev builds (for Nix) - #537
Merged
Merged
Conversation
purcell
added
semver: patch
docs: skip
anisaoshafi
approved these changes
Oct 8, 2026
Contributor
Author
|
Thanks @anisaoshafi |
Collaborator
Thanks @purcell for taking care of lstk <> nix 馃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another case of #529: the fix in #532 wasn't actually sufficient, and if I were to update the Nix derivation to embed the release version in the built binary, the test modified in this PR would fail.
The solution, as in #532, is to skip the test when this is a dev build.
Nix builds have been blocked from automatic updates for a couple of weeks due to the other issue fixed in #534. Unfortunately I don't get notified when attempted updates fail, so I have to check them manually. The next automatic update (due in the next few days) should successfully update nixpkgs to use
lstk1.4.0. Once that has happened, the next release should also update automatically (10 days later) and include the fix in this PR. After that, I would hope to submit a fix to nixpkgs that fixes the version string embedded in the binary.(I'm looking at adding a test for nix builds and updates here, but it involves a little bit of extra workflow machinery and I'm really not sure if it's worthwhile.)