Fix WKTWriter invalid dimensional EMPTY tokens for nested empty geometries - #1225
Open
arimu1 wants to merge 1 commit into
Open
Fix WKTWriter invalid dimensional EMPTY tokens for nested empty geometries#1225arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
…ries When writing empty geometries with Z, M, or ZM ordinates, ensure the dimension marker and EMPTY are separate tokens so WKTReader can round-trip the output. Add regression tests for nested empty Z, M, and ZM cases. Fixes locationtech#1223 Signed-off-by: arimu1 <19286898+arimu1@users.noreply.github.com>
mprins
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WKTWriterso dimensional empty geometries emit separateZ/M/ZMandEMPTYtokens (e.g.MULTILINESTRING Z EMPTY) instead of invalid concatenated tokens likeZEMPTY,MEMPTY, orZMEMPTY.Fixes #1223
Test plan
mvn -pl modules/core -Dtest=WKTWriterTest test— 15 tests, 0 failuresmvn -pl modules/core -Dtest=WKTReadWriteTest,WKTWriterTest,WKTWriterStaticFnTest test— 32 tests, 0 failuresLabels
Contributor notes
19286898+arimu1@users.noreply.github.com-sMade with Cursor