Conversation
- Add workflow_call trigger to check-version.yml, lint.yml, and test.yml - Enable these workflows to be called by ci.yml as reusable workflows - Resolve GitHub Actions workflow validation error
- Add version-check to needs array in ci-success job - Ensure version-check.result is properly accessible - Fix empty string evaluation causing false failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project version to 0.1.4 and makes several improvements to the GitHub Actions workflows by enabling them to be called as reusable workflows. Additionally, it ensures that the CI workflow properly waits for the version check job before reporting success.
Version bump:
README.mdbadge and theSCRIPT_VERSIONvariable insync-ssh-keys.sh. [1] [2]GitHub Actions improvements:
workflow_calltriggers to.github/workflows/check-version.yml,.github/workflows/lint.yml, and.github/workflows/test.ymlto allow these workflows to be used as reusable workflows. [1] [2] [3]ci.ymlworkflow so that the final status check (ci-successjob) depends on theversion-checkjob in addition tolintandtest, ensuring all required checks are complete.- Add workflow_call trigger to check-version.yml, lint.yml, and test.yml