Skip to content

docs(AGENTS): prefer Rrbvec over O(n²) List concat patterns - #151

Closed
RCmerci wants to merge 1 commit into
masterfrom
devin/1790471293-agents-rrbvec
Closed

RCmerci wants to merge 1 commit into
masterfrom
devin/1790471293-agents-rrbvec

Conversation

@RCmerci

@RCmerci RCmerci commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Creates AGENTS.md with OCaml guidance: avoid O(n²) List patterns such as List.concat and repeated List.append on large sequences; when the project already depends on the rrbvec package, use Rrbvec vectors instead.

Link to Devin session: https://app.devin.ai/sessions/cc13a6a77cdd40f89ea6695bff8ff7eb
Open in Devin Desktop: https://app.devin.ai/desktop/session/cc13a6a77cdd40f89ea6695bff8ff7eb?variant=devin
Requested by: @RCmerci

@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-27T01:12:39.647165Z f05699d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f05699d330

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread AGENTS.md
@@ -0,0 +1,3 @@
# AGENTS

- Avoid O(n²) `List` patterns such as `List.concat` and repeated `List.append` on large sequences; when the project already depends on the `rrbvec` package, use `Rrbvec` vectors instead.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not classify every List.concat as quadratic

When an agent touches existing flattening code such as lib/syntax/inline.ml:952, this rule incorrectly labels it an O(n²) violation: OCaml's List.concat is linear in the total number of list elements. This can prompt needless Rrbvec rewrites or dependency changes; narrow the guidance to repeated appends or other incremental concatenation patterns that repeatedly rescan prefixes.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants