Repository navigation
Use the Logseq logo for iOS and Android launcher icons - #65
Merged
Merged
Conversation
Kotlin does not smart-cast a val through require(), so
project(":lui").projectDir rejected the File? and the settings script
failed to compile on CI.
- Regenerated every AppIcon size from logseq/ios AppIcon-512@2x.png (the previous set was the old sun glyph). - Replaced the Android launcher res with the byte-identical set from logseq/android (mipmap-ldpi..xxxhdpi incl. round + monochrome, anydpi-v26 adaptive icons with 16.7% insets, drawable background grid, drawable-v24 foreground, values/ic_launcher_background.xml). - Removed the old vector foreground/monochrome drawables and the duplicate ic_launcher_background color; added android:roundIcon to the manifest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The launcher icons were still the old app icon (sun glyph on a purple field); the in-app logo was already the Logseq mark. This switches both launchers to the Logseq logo, sourced from
logseq/logseqmaster.AppIcon.appiconsetPNG regenerated fromlogseq/ios/.../AppIcon-512@2x.pngat the size each slot requires.logseq/android/.../resbyte-for-byte —mipmap-ldpithroughmipmap-xxxhdpiincludingic_launcher_roundandic_launcher_monochromePNGs,mipmap-anydpi-v26adaptive icons (16.7% inset foreground/background mipmap refs),drawable/ic_launcher_background.xml,drawable-v24/ic_launcher_foreground.xml, andvalues/ic_launcher_background.xml(#FFFFFF). Removed the old vectordrawable/ic_launcher_foreground.xml+drawable/ic_launcher_monochrome.xmland the duplicate color entry incolors.xml; addedandroid:roundIconto the manifest for parity.Link to Devin session: https://app.devin.ai/sessions/3fbb55f8acd849db864aa2e7287c0cea
Open in Devin Desktop: https://app.devin.ai/desktop/session/3fbb55f8acd849db864aa2e7287c0cea?variant=devin
Requested by: @tiensonqin