Skip to content

Cap prediction cone to shortest predBG array length #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quarktwain wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −2
Open

Cap prediction cone to shortest predBG array length #653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions LoopFollow/Controllers/Graphs.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1991,9 +1991,11 @@ extension MainViewController {

var coneData = [ConeChartDataEntry]()
if !allArrays.isEmpty {
let maxLength = min(allArrays.map { $0.count }.max()!, toLoad + 1)
// Cap at the shortest predBG array length so every cone point uses
// the same set of contributing arrays. Matches Trio's ForecastSetup.
let coneLength = min(allArrays.map { $0.count }.min()!, toLoad + 1)
var t = predictionStart
for i in 0 ..< maxLength {
for i in 0 ..< coneLength {
var valuesAtIndex = [Double]()
for arr in allArrays where i < arr.count {
valuesAtIndex.append(arr[i])
Expand Down
Loading