xdrip_cgm: pin dev/main to the current xDrip plugin SHA - #74
Merged
Merged
Conversation
The customization clones the xdrip-client-swift plugin from its default branch (latest). Pin dev/main to the plugin's current master HEAD (e618d674) via a .gitmodules branch ref, so a later deployment-target/API bump landing upstream can't move dev/main onto an incompatible plugin. Requires loopandlearn/lnl-scripts#99 (honor the branch ref); until that is released the branch is ignored and behavior is unchanged.
marionbarker
approved these changes
Aug 30, 2026
marionbarker
left a comment
marionbarker
left a comment
Contributor
There was a problem hiding this comment.
Approve by code review and test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
xdrip_cgmcustomization clones thexdrip-client-swift(xDrip4iOS) plugin. Today the script clones the plugin's default branch (latest), so if the plugin'smasterever moves — e.g. a deployment-target/API bump lands upstream — dev/main would pick it up and could break.Pin dev/main to the plugin's current
masterHEAD by addingbranch = e618d674b1250b9572f148ff3ab360a1eee7f3e2to the.gitmodulesentry.Depends on loopandlearn/lnl-scripts#99 (honor the
branchref). Until #99 is released thebranchis ignored and behavior is unchanged (dev/main clones the same commit anyway, since it is currentmaster).