Skip to content

DM-53958: changes for matching on Nodeset#28

Merged
daues merged 3 commits intomainfrom
tickets/DM-53958
Feb 6, 2026
Merged

DM-53958: changes for matching on Nodeset#28
daues merged 3 commits intomainfrom
tickets/DM-53958

Conversation

@daues
Copy link
Contributor

@daues daues commented Feb 3, 2026

No description provided.

Copy link

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template changes look good. I'm not sure what's going on with the new config/templates. Merge is approved once that's understood/fixed.

@@ -0,0 +1 @@
python/lsst/ctrl/platform/s3df/etc/config No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's going on here (and below with templates). Did something get checked in that shouldn't have been?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I think this is now resolved; the symbolic links were not absolutely necessary, and have been removed.

@timj
Copy link
Member

timj commented Feb 5, 2026

Aren't the soft links needed to allow packages resources to access the files without eups?

@daues
Copy link
Contributor Author

daues commented Feb 5, 2026

Aren't the soft links needed to allow packages resources to access the files without eups?

I originally included the links because I could not setup checked out copies of ctrl_execute and ctrl_platform_s3df, and perform testing. Michelle kicked things around and it turned out that I had not run "scons" in the ctrl_paltfom_s3df checkout directory(was never i the habit of doing that). After running "scons" , the links were no longer needed for my typical mode of work. If there are other considerations, i guess they are harmless.

This reverts commit b8a685b.

Revrting the commit that removed symlinks; the symlinks serve a role
@daues daues merged commit 28aa090 into main Feb 6, 2026
6 checks passed
@daues daues deleted the tickets/DM-53958 branch February 6, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants