Skip to content

fix(api): add program_config account to commit_finalize builders#159

Open
ev0r0x wants to merge 2 commits intomagicblock-labs:mainfrom
ev0r0x:ev0r0x-patch-2
Open

fix(api): add program_config account to commit_finalize builders#159
ev0r0x wants to merge 2 commits intomagicblock-labs:mainfrom
ev0r0x:ev0r0x-patch-2

Conversation

@ev0r0x
Copy link

@ev0r0x ev0r0x commented Mar 21, 2026

Added the delegated_account_owner parameter and included the program config PDA in the accounts metadata before the system program, this is a breaking change for builder calls.

Summary by CodeRabbit

  • Breaking Changes
    • Commit finalization operations now require an additional account configuration parameter.
    • Configuration data is automatically derived and included in commit processing operations.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4c3a14b3-a2a5-40b2-865c-9438333c6feb

📥 Commits

Reviewing files that changed from the base of the PR and between d2fe487 and a84d808.

📒 Files selected for processing (2)
  • dlp-api/src/instruction_builder/commit_finalize.rs
  • dlp-api/src/instruction_builder/commit_finalize_from_buffer.rs

📝 Walkthrough

Walkthrough

Two instruction builder functions in the DLP API are updated to accept an additional delegated_account_owner parameter. Both commit_finalize and commit_finalize_from_buffer now derive a program_config_pda from this owner and include it as a read-only account in the constructed Solana instruction. The size budget calculations are adjusted to account for the program_config_pda as a Tiny account class. Documentation comments are corrected to reference the proper function names.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant