fix: use correct PDA in "Initializes another counter" test#162
Open
beck042 wants to merge 1 commit intomagicblock-labs:mainfrom
Open
fix: use correct PDA in "Initializes another counter" test#162beck042 wants to merge 1 commit intomagicblock-labs:mainfrom
beck042 wants to merge 1 commit intomagicblock-labs:mainfrom
Conversation
## Summary Fixes incorrect PDA usage in the "Initializes another counter" test. ## Problem The test calls `initializeOther()`, which initializes a counter using a different seed (`TEST_PDA_SEED_OTHER`). However, the test was reading and validating the original PDA derived from `TEST_PDA_SEED`. As a result, the test could pass even if `initializeOther()` was broken, since it did not actually verify the correct account. ## Solution - Added a second PDA (`pdaOther`) derived from `TEST_PDA_SEED_OTHER` - Updated the test to use `pdaOther` for account checks and state validation ## Result - The test now correctly validates the behavior of `initializeOther()` - Prevents false positives - Improves overall test reliability
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change introduces a second PDA seed constant ( Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect PDA usage in the "Initializes another counter" test.
Problem
The test calls
initializeOther(), which initializes a counter using a different seed (TEST_PDA_SEED_OTHER). However, the test was reading and validating the original PDA derived fromTEST_PDA_SEED.As a result, the test could pass even if
initializeOther()was broken, since it did not actually verify the correct account.Solution
pdaOther) derived fromTEST_PDA_SEED_OTHERpdaOtherfor account checks and state validationSummary by CodeRabbit