Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughUpdated the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f1730ccb9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (usesQueuedPrivateTransfer) { | ||
| if (!validator.current) { | ||
| throw new Error('Validator not loaded yet for encrypted private transfers'); |
There was a problem hiding this comment.
Limit validator gating to base-origin private transfers
This guard is too broad for the private→base path. transferSpl only requires a validator for the encrypted fromBalance === 'base' route; the fromBalance === 'ephemeral' queue path does not use validator at all. With the current check, an ephemeral→base private transfer now fails whenever validator.current has not been populated yet by the async getIdentity effect (or if that RPC call fails), even though the SDK can build that transfer without a validator.
Useful? React with 👍 / 👎.
Summary by CodeRabbit
Bug Fixes
Chores