Skip to content

chore: upgrade spl example#69

Merged
GabrielePicco merged 1 commit intomainfrom
feat/updade-example
Mar 22, 2026
Merged

chore: upgrade spl example#69
GabrielePicco merged 1 commit intomainfrom
feat/updade-example

Conversation

@GabrielePicco
Copy link
Copy Markdown
Contributor

@GabrielePicco GabrielePicco commented Mar 22, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Added error handling for encrypted private transfers to prevent processing when the system isn't fully initialized.
    • Improved transfer logging to display both source and destination account information.
  • Chores

    • Updated dependencies.

@GabrielePicco GabrielePicco merged commit cd501ef into main Mar 22, 2026
5 of 8 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 22, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8cdd881c-3f09-44a0-aa02-6f57e8e8d216

📥 Commits

Reviewing files that changed from the base of the PR and between b562eb0 and 2f1730c.

⛔ Files ignored due to path filters (1)
  • spl-tokens/app/app/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • spl-tokens/app/app/package.json
  • spl-tokens/app/app/src/App.tsx

Walkthrough

Updated the @magicblock-labs/ephemeral-rollups-sdk dependency to an exact version pin and modified the transfer flow in App.tsx by adding validator guard logic, computing destination ATA, expanding logging, and commenting out account info retrieval calls.

Changes

Cohort / File(s) Summary
spl-tokens/app/app updates
spl-tokens/app/app/package.json, spl-tokens/app/app/src/App.tsx
Updated @magicblock-labs/ephemeral-rollups-sdk from ^0.10.0 to exact version 0.10.1. Enhanced performTransfer with validator guard, added destination ATA computation alongside source ATA, expanded logging to include both public keys and ATAs, and commented out synchronous account-info reads in delegation/undelegation flows. Minor comment text adjustment noted.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Feat/new spl flow #67: Modifies the same transfer flow logic in App.tsx and updates the ephemeral-rollups-sdk dependency.
  • chore: upgrade spl example #68: Applies identical code-level changes to both package.json and App.tsx with validator guard, ATA computation, and commented getAccountInfo calls.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/updade-example

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@GabrielePicco GabrielePicco deleted the feat/updade-example branch March 22, 2026 18:11
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f1730ccb9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 726 to +728
if (usesQueuedPrivateTransfer) {
if (!validator.current) {
throw new Error('Validator not loaded yet for encrypted private transfers');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Limit validator gating to base-origin private transfers

This guard is too broad for the privatebase path. transferSpl only requires a validator for the encrypted fromBalance === 'base' route; the fromBalance === 'ephemeral' queue path does not use validator at all. With the current check, an ephemeral→base private transfer now fails whenever validator.current has not been populated yet by the async getIdentity effect (or if that RPC call fails), even though the SDK can build that transfer without a validator.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant