fix: upgrade helius-laserstream to fix gRPC connection leaks#3
fix: upgrade helius-laserstream to fix gRPC connection leaks#3
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Cargo.toml`:
- Line 10: Replace the floating git branch pin for the dependency
helius-laserstream in Cargo.toml with an immutable commit SHA: locate the
dependency entry that currently uses branch = "v0.2.8+conn-fix" and change it to
use rev = "<commit-sha>" (the exact commit SHA from that branch) so builds are
reproducible; keep the git URL and remove the branch key once rev is set.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
bmuddha
left a comment
There was a problem hiding this comment.
LGTM, we can merge it, I'll see whether we can upgrade the router with this version
Summary
Upgrade helius-laserstream SDK to v0.2.8+conn-fix to fix leaking gRPC connections.
NOTE: they use the typescript version for tagging.
The new version applies the connection management fix from
helius-labs/laserstream-sdk@main...magicblock-labs:laserstream-sdk:v0.2.8+conn-fix
to prevent gRPC connection leaks to Helius.
Details
helius-laserstream = "0.1.5"to git dependency pointing to the custom branch containing the connection fixSummary by CodeRabbit