Skip to content

fix: upgrade helius-laserstream to fix gRPC connection leaks#3

Open
thlorenz wants to merge 1 commit intomasterfrom
thlorenz/fix-connection-leak
Open

fix: upgrade helius-laserstream to fix gRPC connection leaks#3
thlorenz wants to merge 1 commit intomasterfrom
thlorenz/fix-connection-leak

Conversation

@thlorenz
Copy link

@thlorenz thlorenz commented Mar 25, 2026

Summary

Upgrade helius-laserstream SDK to v0.2.8+conn-fix to fix leaking gRPC connections.
NOTE: they use the typescript version for tagging.

The new version applies the connection management fix from
helius-labs/laserstream-sdk@main...magicblock-labs:laserstream-sdk:v0.2.8+conn-fix
to prevent gRPC connection leaks to Helius.

Details

  • Updated dependency from helius-laserstream = "0.1.5" to git dependency pointing to the custom branch containing the connection fix
  • This ensures proper cleanup of gRPC connections and prevents resource leaks in the syncer

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to enhance reliability and stability.

@coderabbitai
Copy link

coderabbitai bot commented Mar 25, 2026

Walkthrough

The helius-laserstream dependency is modified to source from a git repository on the v0.2.8+conn-fix branch instead of the published crates.io version 0.1.5. This affects dependency resolution and build sourcing.

Changes

Cohort / File(s) Summary
Dependency Source Update
Cargo.toml
Modified helius-laserstream to use git source at https://github.com/magicblock-labs/laserstream-sdk on branch v0.2.8+conn-fix instead of crates.io version 0.1.5.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: upgrading helius-laserstream to fix gRPC connection leaks, which directly matches the changeset's objective and the dependency update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch thlorenz/fix-connection-leak

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thlorenz thlorenz marked this pull request as draft March 25, 2026 09:45
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Cargo.toml`:
- Line 10: Replace the floating git branch pin for the dependency
helius-laserstream in Cargo.toml with an immutable commit SHA: locate the
dependency entry that currently uses branch = "v0.2.8+conn-fix" and change it to
use rev = "<commit-sha>" (the exact commit SHA from that branch) so builds are
reproducible; keep the git URL and remove the branch key once rev is set.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 39f65c80-e88e-428f-b79b-571d82d8c0fe

📥 Commits

Reviewing files that changed from the base of the PR and between c853232 and 9d5d8b7.

📒 Files selected for processing (1)
  • Cargo.toml

@thlorenz thlorenz marked this pull request as ready for review March 25, 2026 09:47
Copy link
Collaborator

@bmuddha bmuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can merge it, I'll see whether we can upgrade the router with this version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants