BaseMapperTest#5
Open
Kleduy wants to merge 2 commits intomaintaina-com:FRAMEWORK_6_0from
Open
Conversation
|
This PR should have the FRAMEWORK_6_0 branch as a target. Not master |
|
Can we please just remove the master branch of maintaina-com/Rdo? The
"default" branch should be configured to FRAMEWORK_6_0 - I am unsure why
we did not do this for this repo.
Am 17.05.2022 um 15:15 schrieb midahp:
This PR should have the FRAMEWORK_6_0 branch as a target. Not master
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE56QBXN5HHXR7NMQQDF5DVKOLWFANCNFSM5WBOSURQ>.
You are receiving this because you are subscribed to this
thread.Message ID: ***@***.***>
--
Ralf Lang
Linux Consultant / Developer
Tel.: +49-170-6381563
***@***.***
B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg /http://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537
|
|
Looking at some repos, it seems like we still have quite a few repos that have the master branch. All of which have the FRAMEWORK_6_0 as default though (including this one). |
ralflang
requested changes
Aug 15, 2022
ralflang
left a comment
ralflang
left a comment
There was a problem hiding this comment.
Please run this through php-cs-fixer with PSR 12 rules and fix the mentioned issues (or what's left of them after CS fixing)
|
|
||
| } | ||
|
|
||
| public function testsetFactory(){ |
There was a problem hiding this comment.
This should be testSetFactory, not testsetFactory
| public function testsetFactory(){ | ||
| $this->base=$this->createMock(BaseMapper::class); | ||
|
|
||
| $test=$this->getMockBuilder('Factory')->getMock(); |
|
|
||
| //@return Factory The Factory | ||
|
|
||
| public function test__construct(){ |
There was a problem hiding this comment.
rename to testConstructor, if needed at all
| $adapter=$this->createMock(Horde_Db_Adapter::class); | ||
|
|
||
| $q=new Factory($adapter); | ||
| $c=$q->__construct($adapter); |
There was a problem hiding this comment.
This looks wrong. You don't call the constructor on an existing object.
|
|
||
| } | ||
| */ | ||
| public function testcreateClassDoesNotExist(){ |
|
|
||
| } | ||
|
|
||
| public function testcreateClassWithoutAdapter(){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup Test