Refactor core modules + revamp all demo pages#243
Merged
ianmcburnie merged 40 commits intomasterfrom Mar 31, 2026
Merged
Conversation
Member
Author
|
@saiponnada Adding you for visibility, I do not expect you to review all these files, but as a high level want to make sure you are aware of and approve this refactor. |
saiponnada
approved these changes
Mar 31, 2026
Contributor
saiponnada
left a comment
There was a problem hiding this comment.
Looks good to me — I’m aligned with the intent here. I’ve skimmed through at a high level. Appreciate you looping me in.
LuLaValva
approved these changes
Mar 31, 2026
Contributor
LuLaValva
left a comment
There was a problem hiding this comment.
Looks like Claude did a great job here! I didn't read through the docs changes, but nothing big stuck out to me on the JS side. Just a few comments about the TODO comments that were added, but regardless I think this is good to merge
…ght server command Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor core modules + revamp all demo pages
Summary
makeup-expander, makeup-keyboard-trap, makeup-screenreader-trap, makeup-modal, makeup-navigation-emitter, makeup-roving-tabindex, makeup-active-descendant, makeup-typeahead, makeup-next-id, makeup-prevent-scroll-keys
-separated sections, and suppressed favicon requests
Test plan
🤖 Generated with https://claude.com/claude-code