Set the compiled file in dist as the main file#976
Open
trygveaa wants to merge 1 commit intomapbox:mainfrom
Open
Set the compiled file in dist as the main file#976trygveaa wants to merge 1 commit intomapbox:mainfrom
trygveaa wants to merge 1 commit intomapbox:mainfrom
Conversation
This lets people just import @mapbox/mapbox-gl-draw instead of having to import @mapbox/mapbox-gl-draw/dist/mapbox-gl-draw.js. It's standard practise to set the compiled file in main, and most other packages including mapbox-gl does so.
trygveaa
force-pushed
the
set-dist-file-as-main
branch
from
13e7190 to
2791013
Compare
Contributor
|
It looks like the change proposed by this PR was made by #1032, so this can be closed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets people just import @mapbox/mapbox-gl-draw instead of having to
import @mapbox/mapbox-gl-draw/dist/mapbox-gl-draw.js. It's standard
practise to set the compiled file in main, and most other packages
including mapbox-gl does so.