Fix Toast right padding when closeButton is false with an action button - #257
Open
tristen wants to merge 2 commits into
Open
Fix Toast right padding when closeButton is false with an action button#257tristen wants to merge 2 commits into
tristen wants to merge 2 commits into
Conversation
The pr12 compensation for a missing close button was applied whenever closeButton was false, ignoring whether an action button was present. With an action button and no close button, this added surplus padding to the right of the action. Only apply the compensation when neither a close button nor an action button is rendered. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace parentElement/querySelector access with a data-testid on the button-group span so the tests query through Testing Library. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
Toastis rendered withcloseButton={false}and anactionbutton, an unwanted gap appears to the right of the action button. This fixes that