MLE-32445 Post release cleanup - #1126
Merged
Merged
Conversation
…rom-master PDP-1182: Remove per-repo pr-workflow.yaml
MLE-31994 Update version to 4.2.0
MLE-31583 Node Client 4.2.0 Release
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
MLE-31583 Create npm-publish-packages.yml
…patch MLE-31583 Force public npm repo for publishing
MLE-31583 Update npm-publish-packages.yml to use NodeJS 24
MLE-31583 explicitly run prepublishOnly to generate SBOM
rjdew-progress
requested review from
RitaChen609,
jonmille,
ngodugu-marklogic and
rjrudin
as code owners
September 11, 2026 15:13
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical workflow issues can cause unintended publishing and prevent reliable installation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates package metadata to version 4.3.0 and adds GitHub Actions npm publishing automation.
Changes:
- Bumps package and lockfile versions.
- Updates the README release requirement.
- Adds build, validation, and npm publishing workflow automation.
File summaries
| File | Summary and findings |
|---|---|
README.md |
Updates the documented release version. |
package.json |
Bumps version to 4.3.0. Moderate (2 votes): NOTICE.txt and SBOM metadata still identify 4.1.0. Nit (2 votes): add the 4.3.0 changelog entry and release notes. |
package-lock.json |
Synchronizes lockfile metadata for the new package version. |
.github/workflows/npm-publish-packages.yml |
Critical (3 votes): publish: false is ignored, allowing unintended publishing. Critical (1 vote): npm ci relies on the Harness registry without credentials while the workflow configures npmjs. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| node-version: '24' | ||
| registry-url: 'https://registry.npmjs.org' | ||
| package-manager-cache: false # never use caching in release builds | ||
| - run: npm ci |
| - run: npm run test:types | ||
| - run: npm run prepublishOnly | ||
| # TODO: Create a way to run non-integration tests that don't rely on a MarkLogic Server instance | ||
| - run: npm publish --registry=https://registry.npmjs.org # Or: npm stage publish |
| "description": "The official MarkLogic Node.js client API.", | ||
| "homepage": "https://github.com/marklogic/node-client-api", | ||
| "version": "4.1.0", | ||
| "version": "4.3.0", |
| "description": "The official MarkLogic Node.js client API.", | ||
| "homepage": "https://github.com/marklogic/node-client-api", | ||
| "version": "4.1.0", | ||
| "version": "4.3.0", |
jonmille
approved these changes
Sep 11, 2026
RitaChen609
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.