Fix dedicated MMS file-transfer session lifetime#80
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field evidence
The relay file directory is now decoded correctly (
FRA00019, 119 KB, CFG/DAT/INF), but Download still failed immediately with first-chance exceptions in this order:OperationCanceledExceptionInvalidOperationExceptionInvalidDataExceptionRoot cause
The Fault Record window replaces its operation cancellation token between Scan and Download. The dedicated MMS receive pump had been linked to the Scan token, so replacing/cancelling that completed UI token stopped confirmed-service response routing while the association still appeared to be
MmsInitiated.Changes
MmsInitiated + transport connected + receive pump runningbefore reusing the dedicated associationThe transport is already file-type agnostic: the service downloads each returned remote path through MMS FileOpen/FileRead/FileClose. COMTRADE is only the grouping/presentation layer, so changing the UI to “all file types” would not fix this transport-lifetime defect.