Synthesize PR html_url so dedup drops duplicate lines#330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Running
./github-nippouproduced duplicate lines for the same PR:(*Events).uniqdedups by the URL pulled out of each event payload (htmlURLinlib/events.go). For PR-related events it readpayload.PullRequest.HTMLURL, but the/users/{user}/eventsAPI returns thepull_requestpayload withouthtml_url(onlynumberis set). Verified directly:This caused two distinct symptoms:
PullRequestEventon PR Replace deprecated 'app-id' input in create-github-app-token #329 (dedup key"") and the correspondingIssueCommentEventon the same PR (dedup key/pull/329fromissue.html_url) had different keys, so both passeduniq.Format.Linethen resolved both to the same/pull/329URL — producing two identical lines.PullRequestEvent/PullRequestReviewEvent/PullRequestReviewCommentEventmapped to"", so only the first one surviveduniq. Other PRs touched only by these event types in the same range were dropped from the output entirely. In my reproduction PRs Support DiscussionEvent #326 and Fix deprecate warnings #327 were missing.Changes
pullRequestHTMLURL(event, number)which synthesizeshttps://github.com/{repo}/pull/{number}fromevent.Repo.Name+payload.PullRequest.Number. This matches the/pull/NformIssueCommentEvent.Issue.HTMLURLalready returns for PR comments, so dedup keys align across the two event families.htmlURLto use it. The nil check moves frome.PullRequest.HTMLURL != niltoe.PullRequest.Number != nil, sinceNumberis what the API actually populates.IssuesEvent/IssueCommentEvent/DiscussionEventare unchanged — their payloadhtml_urlfields are populated correctly by the API.Verification
Before:
After: