Fix library name for MaxMind DB Reader PHP extension

[macintoshplus]

Fix the library name to allow build the PHP extension dll

[gemini-code-assist]

Summary of Changes

Hello @macintoshplus, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request fixes the library name used during the build process of the MaxMind DB Reader PHP extension. The incorrect library name was preventing the successful creation of the extension's DLL file. This correction ensures that the extension can be built and used correctly.

Highlights

• Library Name Correction: The library name 'libmaxminddb.lib' has been corrected to 'maxminddb.lib' in the ext/config.w32 file.
• Build Process Adjustment: This change specifically addresses an issue preventing the successful building of the PHP extension DLL for the MaxMind DB Reader.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the library name for the Windows build of the PHP extension, changing it from libmaxminddb.lib to maxminddb.lib. This is a good fix. However, the change introduces an inconsistency in a related warning message, which could cause confusion. I've left a comment with a suggestion to address this.

[gemini-code-assist]

While this change correctly updates the library name to maxminddb.lib, the corresponding warning message on line 8 is now inconsistent as it still refers to libmaxminddb.lib. To avoid confusion for developers if the build fails on Windows, please also update the warning message.

For consistency, I suggest updating line 8 as follows:

- 		WARNING('Could not find maxminddb.h or libmaxminddb.lib; skipping');
+ 		WARNING('Could not find maxminddb.h or maxminddb.lib; skipping');

[horgh]

Thank you! It looks like the comment from gemini-code-assist regarding the error message would be worth updating as well. Would you be willing to update that too?

For future readers: I found that we used to call the library libmaxminddb for the Windows build, but this was removed in maxmind/libmaxminddb#258. The build is apparently currently working on PECL as there is an old libmaxminddb there that does not include that rename: https://windows.php.net/downloads/pecl/deps/ (1.5.0).

[gemini-code-assist]

Thank you for your feedback, @horgh! I appreciate you pointing out the historical context regarding the library name change.

Regarding your request to update my previous comment, I am currently unable to modify past comments or take direct actions on the pull request. My function is limited to providing responses and suggestions within new comments.

I've noted your valuable information about the libmaxminddb name change and its impact on PECL builds. This context is very helpful for understanding the fix in this PR.

[horgh]

I'll go ahead and merge this. Thanks again!