Basic support for CocoaPods tooling - #43
Conversation
|
Warning Review limit reached
Next review available in: 33 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe SDK adds CocoaPods packaging through a new podspec. CI validates the podspec and synchronizes its version with ChangesCocoaPods distribution
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitRepository
participant CocoaPods
participant GitHubActions
Developer->>GitRepository: Adds podspec and release tag
CocoaPods->>GitRepository: Fetches SDK from tag
GitHubActions->>GitRepository: Reads podspec and SDK versions
GitHubActions->>CocoaPods: Runs podspec lint
CocoaPods-->>GitHubActions: Returns validation result
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 34: Update the README installation example to use tag 0.1.1, the first
tag containing MinFraudDevice.podspec. Ensure the release version in
SDKConfig.swift and MinFraudDevice.podspec is set consistently to 0.1.1 before
creating or referencing that tag.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 1f1dd4d1-4d47-447c-aaaa-e3a81f2d5659
📒 Files selected for processing (5)
.github/workflows/ci.ymlCHANGELOG.mdMinFraudDevice.podspecREADME.dev.mdREADME.md
20d8ab6 to
d8fc12f
Compare
mm-kevcenteno
left a comment
mm-kevcenteno
left a comment
There was a problem hiding this comment.
A couple of questions that might actually be requests for changes.
| @@ -0,0 +1,23 @@ | |||
| Pod::Spec.new do |s| | |||
| s.name = 'MinFraudDevice' | |||
| s.version = '0.1.0' | |||
There was a problem hiding this comment.
Does this need to be 0.1.1 or do we have to wait for the tag to exist before updating the value?
There was a problem hiding this comment.
It will need to be 0.1.1, but at the point of this PR that version doesn't exist yet so I didn't want to include it in the documentation. It'll be updated in a release PR immediately following.
| uses CocoaPods, add the pod to your `Podfile`, pointing at a release tag: | ||
|
|
||
| ```ruby | ||
| pod 'MinFraudDevice', :git => 'https://github.com/maxmind/device-ios.git', :tag => '0.1.0' |
There was a problem hiding this comment.
Does this need to be 0.1.1 or do we have to wait for the tag to exist before updating the value?
There was a problem hiding this comment.
Ah, code rabbit already caught this.
There was a problem hiding this comment.
It will need to be 0.1.1, but at the point of this PR that version doesn't exist yet so I didn't want to include it in the documentation. It'll be updated in a release PR immediately following.
2 participants
Noting that the official CocoaPods registry is moving into read-only mode in December this year, we have customers who still use and depend on CocoaPods tooling for their apps. We do not want to add code to the official registry as this library is new and is likely to need updates; we don't want to have a buggy version locked in the official registry when it becomes read-only.
We can still support customers that use CocoaPods tooling by adding a Podspec file to the repo, and this PR does that.
Summary by CodeRabbit
New Features
Documentation
Tests