Repository navigation
fix(player): prevent slider snapping back when seeking while paused - #2591
Closed
GadhiyaRaj wants to merge 1 commit into
Closed
GadhiyaRaj wants to merge 1 commit into
GadhiyaRaj wants to merge 1 commit into
Conversation
Owner
|
Thanks for tracking this down and for the clear repro! We ended up fixing it with a simpler change at the source: while paused, the player handlers stop their progress ticker, so a seek never reached the shared timeline. The handlers now publish the new position on every seek while paused (maxrave-dev/core@5d3fb4c, bumped in c539920), which covers every seek bar plus lyric taps and system media controls with no UI changes. Closing this one, appreciate the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Prevents the playback slider from snapping back to its old position when dragged and released while paused
Linked issue
Closes #2480
Checklist