Open
Conversation
Added ADC_MULTIPLIER (default=1) to v3 board. Added correct multiplier to ini of WP.
seconded |
This was referenced Feb 3, 2026
oltaco
suggested changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
I think it would be cleaner to change
return (5.42 * (3.3 / 1024.0) * raw) * 1000; to return (ADC_MULTIPLIER * (3.3 / 1024.0) * raw) * 1000;
And add -D ADC_MULTIPLIER=5.42 to the other variants which use this board (heltec_v3 and heltec_tracker), and then you can use the true multiplier of 8.4 for the heltec wireless paper.
Collaborator
|
Please change base branch to 'dev' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ADC_MULTIPLIER (default=1) to v3 board.
Added correct multiplier to ini of WP.
I think this is the easiest fix for the Heltec Wireless Paper not showing correct voltage.