Encourage adoption of regions and multi-byte hashes#2840
Open
ZjMNZHgG5jMXw wants to merge 1 commit into
Open
Conversation
9be8825 to
d1acd71
Compare
d1acd71 to
c4eef74
Compare
c4eef74 to
598c0e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch defines two new settings for repeaters.
repeat.unrestricted.hops(default 64) defines the number of hops for which the repeater will not apply any restrictions to packets.repeat.restrict.path.hash.size(default 1) defines the minimum path hash size which the repeater will require for repeating packets with restrictions applying.How
The repeater will first look whether restrictions should apply to incoming packets by evaluating their path length and comparing them with
repeat.unrestricted.hops. If the path length is exceeding this maximum and restrictions apply, packets without transport codes (aka scope or region) will be discarded. Packets with transport codes will be considered for repeating if their path hash size is at least matching the minimumrepeat.restrict.path.hash.size. All other mainstream repeater restrictions (flood.max,flood.max.unscoped,flood.max.advert, scope/region logic, etc.) apply after these new checks.The default values make sure that the new settings won't affect the repeater until explicitly set.
Why
The recommended settings will create a safe zone of three hops which newbies can use to get in contact with others no matter whether they have regions or hash sizes set to modern values. Other mesh users in this hop proximity can instruct these newbies how to adjust their settings for achieving a wider message distribution range, for instance by using regions and avoiding ID/path collisions by using multi-byte hash sizes.
Recommended settings