Add configurable ACK timeout multiplier for companion#2843
Open
ViezeVingertjes wants to merge 2 commits into
Open
Add configurable ACK timeout multiplier for companion#2843ViezeVingertjes wants to merge 2 commits into
ViezeVingertjes wants to merge 2 commits into
Conversation
ViezeVingertjes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the ACK wait window after a DM send is fixed, causing retries to fire before an ACK has had a realistic chance to arrive on congested or long-range links. This adds an ack_timeout_mult preference (1–10, default 1) that multiplies the entire computed timeout window, so user who are willing to wait longer can reduce retry spam without changing any other radio parameters.
Protocol changes validated on a T-Beam SX1276, should be backwards compatible but also would need clients (@liamcottle) to make it available in the app.